Skip to content

[FSSDK-11082] fix: big integer conversion issue #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

muzahidul-opti
Copy link
Contributor

@muzahidul-opti muzahidul-opti commented Jan 17, 2025

Summary

Test plan

  • All previous test cases should be passed

Issues

@muzahidul-opti muzahidul-opti marked this pull request as ready for review January 17, 2025 14:28
@muzahidul-opti muzahidul-opti requested a review from a team as a code owner January 17, 2025 14:28
@muzahidul-opti muzahidul-opti requested a review from jaeopt January 17, 2025 17:12
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - interesting we didn't get any request for long integer support in java-sdk before :)

@iago-zwift
Copy link

I wonder why also, but this should fix the issue we're having. Any news on when the version with this fix will be released?

@muzahidul-opti
Copy link
Contributor Author

I wonder why also, but this should fix the issue we're having. Any news on when the version with this fix will be released?

We are running out of time this sprint. Hopefully, we can release it in the next sprint.

@iago-zwift
Copy link

Thank you @muzahidul-opti!

@muzahidul-opti muzahidul-opti merged commit ab02b49 into master Feb 19, 2025
13 of 17 checks passed
@muzahidul-opti muzahidul-opti deleted the fix-big-integer branch February 19, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants